Skip to content

Conversation

@Blixibon
Copy link
Member

@Blixibon Blixibon commented May 26, 2025

This PR adds custom model support to most HL2 NPCs which did not already have it. It uses the DefaultOrCustomModel macro from here.

This PR is based directly on map-labs-source#20 on the Map Labs mod template repo.


PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

@Blixibon Blixibon force-pushed the mapbase/feature/improved-npc-custom-model-support branch from 3c6d47a to bd4aeca Compare May 26, 2025 14:23
@Blixibon
Copy link
Member Author

I removed instances of #ifdef MAPBASE since the DefaultOrCustomModel macro already uses it internally.

I also removed the custom model implementation for zombie torsos because it was preventing zombies from turning into torsos from damage after spawning. npc_zombie_custom can be used instead for zombies with custom torso models.

Co-authored-by: Maestra Fenix <fenixmaestro@gmail.com>
@Blixibon Blixibon force-pushed the mapbase/feature/improved-npc-custom-model-support branch from bd4aeca to b1f65f0 Compare May 29, 2025 04:25
Copy link
Collaborator

@arbabf arbabf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@Blixibon Blixibon merged commit 3d435c6 into mapbase-source:develop May 30, 2025
4 checks passed
@Blixibon Blixibon deleted the mapbase/feature/improved-npc-custom-model-support branch May 30, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants