Fix typo in CBaseCombatWeapon::WeaponClassFromString #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
credit goes to Petercov for finding this not me
Blixibon
approved these changes
May 30, 2025
Member
Blixibon
left a comment
Blixibon
left a comment
There was a problem hiding this comment.
I wrote this code several years ago to try to group weapons together in Mapbase's dynamic interaction expansions. This typo wouldn't have presented there, but I don't think there would be anything negatively affected by fixing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credit goes to Petercov for finding this not me
(i have no idea what this fixes/breaks)
Does this PR close any issues?
not that I know of
PR Checklist
developbranch OR targets another branch with a specific goal in mind