Skip to content

Conversation

@nooodles-ahh
Copy link

This PR reimplements BSPZip and BSPPack with the intention of addressing 2 key issues. The first is that increasing certain BSP limits results in being unable to build cubemaps due to the lump size differences, this is addressed by the fact that future compilations of bsppack would have the correct lump sizes. The second is a sound and shader caching issue as described here ValveSoftware/Source-1-Games#7175, this is addressed using the solution proposed here ValveSoftware#1322 meaning all mp3, wav and vcs files are not compressed.

If you'd like to fix the shader bug directly, you can use this older version of a Mobster VIP map to test the bug with: https://tf2maps.net/downloads/brooklynn-mobster-vip.19180/version/57402/download
To reproduce the bug, you need to load the map, change to a different map and load this map again. If you see a black square on your screen once you've spawned, the bug has been reproduced.

Using the above map as a test I can confirm that that after recompressing it with the changes it now appears to work. In my case the original map would crash on the second load rather than show a black square. The map size is slightly larger at 43.1mb from 42.7mb, which is expected as mp3's and wav's don't compress very well.

The contents of bsppack.cpp were originally posted by ficool2 in the Valve Modding Community Discord so I have authored the commit under his name.


PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants