3D skybox in water reflection #485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toggable via `r_3dsky_water`, expensive mode should be enabled though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSGO has had this feature since the Danger Zone update (in December 2018), and GMOD includes it in the dev branch (as of when I created this PR). So I decided to implement something similar. I actually tried doing it a long time ago and found out how to implement it.
Controlled by
r_3dsky_water(defaults to 1) cvar. The expensive mode (or "Reflect All" in the settings) must also be enabledI don’t see any point in adding
$reflect3dskybox(it possible btw), since it doesn’t really make sense to control the 3D skybox separately on a per-material basis, that would just be weird to see 3d sky, but not in waterIt can be improved, but I don't know how (it doesn't render some props and detail props are gone)
Does this PR close any issues?
No
PR Checklist
developbranch OR targets another branch with a specific goal in mind