Add filtername to brush doors from HL:S
#492
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to enable the
filternameKV onfunc_door,func_door_rotating, andfunc_water, which is present in the SDK, but is ifdefed to only be compiled in HL:S+HLDMS. This PR modifies the relevant ifdefs to also apply to Mapbase, without enabling any code unrelated to the block filter.The
filternameKV indicates a filter to determine entities (other than players) that can block the door (could be useful for NPCs). It is actually present in the vanilla FGD entry for func_door, despite not working outside of HL:S. It should be moved to the Door baseclass. A modified FGD entry is as such:This is flagged as a draft, because it needs to be tested further (and apparently doesn't compile).
Does this PR close any issues?
PR Checklist
developbranch OR targets another branch with a specific goal in mind