This repository has been archived by the owner on Oct 30, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some non-invasive optimizations to
coaleseSingle
taking advantage of the fact that covers are sorted in relev, score descending order. Since the cutoff for coalesce is 40 features, we can also short circuit intelligently based on this cutoff.I've tested this with carmen + IRL scenarios to consider it ready for tagging.
Benchmark numbers
IRL benchmarks are more meaningful but for the synthetic
coalesceSingle()
scenarios:master
early-death