This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
allow auto and none keywords for symbolizers #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebulon42
force-pushed
the
auto-none
branch
4 times, most recently
from
dffe48a to
28c3b8f
Compare
|
Has now more tests, but I overlooked that also |
…ent, output empty symbolizer when a symbolizer rule with 'auto' is present, fixes mapbox#462, mapbox#18
nebulon42
changed the title
|
mapnik-reference has been updated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rules that work on the whole symbolizer. You can either suppress it (none) or output the symbolizer with default values (auto). Auto does not work for shield and text symbolizer because they don't support default values for all their attributes. Symbolizer rules are never inherited. This could be changed maybe for auto, but cannot be changed for none. The reason is that if symbolizer rules with none would be inherited they would suppress all similar symbolizers down the inheritance chain. How would you stop them?
depends on mapnik/mapnik-reference#139fixes #462, #18
needs more tests