Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAPSAPI-2426: Allow stream lambdas to have FilterCriteria defined #147

Merged
merged 12 commits into from
Mar 27, 2024
Merged

MAPSAPI-2426: Allow stream lambdas to have FilterCriteria defined #147

merged 12 commits into from
Mar 27, 2024

Conversation

branyip
Copy link
Contributor

@branyip branyip commented Mar 22, 2024

Allow the streamlambda shortcut to have a FilterCriteria optionally defined.

Test

  • Created a dev release 8.1.0-dev
  • Installed and deployed on mts-queue-staging-rerouter stack
  • Confirmed drop in lambda invocations

Deploy diff:

image

Invocation drop

image

The 3 invocations are due to the event source have 3 UNAVAILABLE records (not counting OVERRIDE)
image

@branyip branyip self-assigned this Mar 22, 2024
@branyip branyip requested a review from a team as a code owner March 22, 2024 21:41
bilindhajer
bilindhajer requested changes Mar 26, 2024
View reviewed changes
lib/shortcuts/stream-lambda.js Show resolved Hide resolved
lib/shortcuts/stream-lambda.js Show resolved Hide resolved
bilindhajer
bilindhajer requested changes Mar 27, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
bilindhajer
bilindhajer approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@bilindhajer bilindhajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@bilindhajer bilindhajer merged commit 26c4830 into master Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilindhajer bilindhajer bilindhajer approved these changes

@michaeldussert michaeldussert Awaiting requested review from michaeldussert michaeldussert was automatically assigned from mapbox/orchestration

Assignees

@branyip branyip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@branyip @bilindhajer