Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option for lambda log retention period #153

Merged
merged 2 commits into from
Jul 31, 2024
Merged

add option for lambda log retention period #153

merged 2 commits into from
Jul 31, 2024

Conversation

ryndaniels
Copy link
Contributor

Rather than having this be hard-coded to always be 14 days, let's make it an option that defaults to 14 days.

@ryndaniels ryndaniels requested a review from a team as a code owner July 29, 2024 07:43
oielbanna
oielbanna previously approved these changes Jul 29, 2024
View reviewed changes
Copy link

@oielbanna oielbanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the CHANGELOG before merging this?

bilindhajer
bilindhajer requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@bilindhajer bilindhajer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ryn, thank you for making these changes. I believe you will have to run the update API docs command and include those changes as part of this PR.

@ryndaniels ryndaniels merged commit 6ca5f3c into master Jul 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilindhajer bilindhajer bilindhajer approved these changes

@oielbanna oielbanna oielbanna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryndaniels @bilindhajer @oielbanna