Indexed vertices API #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
I should probably also make this optional. |
|
what's the status of this? |
|
@kkaefer never tried it in practice but it works on the earcut end and I can quickly rebase the branch to work on master. Do you think it should be the default behavior? |
|
@mourner we're exclusively doing indexed draw calls in native, so we'd need some way of doing this anyway. |
|
@kkaefer OK, I'll look if this can be merged to master in a way that doesn't degrade performance (e.g. making it optional). |
|
Another pull request for the same: #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the API to return indexed vertices. Closes #4.
We need to evaluate the approach in the real world first before making a change like this because it comes with a performance cost of ~15-20%.
This also breaks the 3D vertices use cases, we need to think about it API-wise.