Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add id feature property to tiles #59

Closed
wants to merge 4 commits into from

Conversation

gmaclennan
Copy link

@gmaclennan gmaclennan commented May 16, 2016

GeoJSON supports the id field on Feature Objects. Vector Tile spec also supports id on features. Currently geojson-vt does not copy this id property into the vector tiles. This PR fixes that.

TODO:

  • Update tests.

@gmaclennan
Copy link
Author

ok @mourner this is ready. My only update to the tests was adding ids to the expected fixtures. I pretty-printed us-states-tiles.json first before updating so in that commit you can clearly see what has been changed. Since some fixtures don't have ids in the original GeoJSON and others do, that works as a test for whether ids are added correctly as needed (and no undefined ids are added)

@jfirebaugh
Copy link
Contributor

@gmaclennan Can you make this two logical, standalone commits?

  1. Pretty print tile JSON
  2. Add id property

@gmaclennan
Copy link
Author

See #60

@gmaclennan gmaclennan closed this May 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants