No default constructor for geometry

Defaulting to the point 0,0 is not particularly useful and could hide bugs.
mapbox · Apr 29, 2016 · c961ad2 · artemp · May 3, 2016 · c961ad2
1 parent a86baac
commit c961ad2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/include/mapbox/geometry/geometry.hpp b/include/mapbox/geometry/geometry.hpp
@@ -31,6 +31,12 @@ struct geometry : geometry_base<T>
 {
     using value_type = T;
     using geometry_base<T>::geometry_base;
+
+    /*
+     * The default constructor would create a point geometry with default-constructed coordinates;
+     * i.e. (0, 0). Since this is not particularly useful, and could hide bugs, it is disabled.
+     */
+    geometry() = delete;
 };
 
 template <typename T, template <typename...> class Cont>

diff --git a/tests/test.cpp b/tests/test.cpp
@@ -74,9 +74,6 @@ void testGeometry() {
 void testGeometryCollection() {
     geometry_collection<double> gc1;
     assert(gc1.size() == 0);
-
-    geometry_collection<double> gc2(10);
-    assert(gc2.size() == 10);
 }
 
 int main() {