Updated to use hpp-skel #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should note that I added the |
GretaCB
reviewed
Dec 11, 2017
| @@ -19,12 +19,17 @@ struct point | |||
| T y; | |||
| }; | |||
|
|
|||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Wfloat-equal" | |||
There was a problem hiding this comment.
If we do not, then compare operations on any base class using a double or float type would have a compile warning and fail. This is a known issue that is being considered in #49. Until we figure out a great way to resolve this, I don't want to cause compilation failures.
GretaCB
reviewed
Dec 11, 2017
scripts/liftoff.sh
Outdated
| @@ -0,0 +1,30 @@ | |||
| #!/usr/bin/env bash | |||
…fixed formating, pulled in other changes from hpp-skel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to use the layout of https://github.com/mapbox/hpp-skel
-Wfloat-equalerrors inpoint.hpp/cc @springmeyer @artemp @jfirebaugh @GretaCB @mapsam