Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Maps SDK v5.8.0 #392

Merged
merged 4 commits into from
May 4, 2020
Merged

Maps SDK v5.8.0 #392

merged 4 commits into from
May 4, 2020

Conversation

jmkiley
Copy link
Contributor

@jmkiley jmkiley commented Mar 18, 2020

This PR is for testing v5.8.0.

@1ec5
Copy link
Contributor

1ec5 commented Mar 18, 2020

I’ve updated StaticSnapshotExample to avoid capturing the snapshotter in the completion handler, which is no longer necessary as of mapbox/mapbox-gl-native-ios#211.

@nishant-karajgikar
Copy link
Contributor

nishant-karajgikar commented Apr 1, 2020

@jmkiley any idea why circleCI is even running here? I thought this was a bitrise project.

@jmkiley
Copy link
Contributor Author

jmkiley commented Apr 2, 2020

@nishant-karajgikar It looks like we still have a CircleCI webhook on Github, so I'll remove that. Thanks!

@nishant-karajgikar nishant-karajgikar marked this pull request as ready for review April 7, 2020 22:48
Copy link
Contributor

@captainbarbosa captainbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're changing snapshotter code here, don't forget to PR the website update in ios-sdk.

@jmkiley jmkiley merged commit 5db3a2a into master May 4, 2020
@jmkiley jmkiley deleted the ios-v5.8.0 branch May 4, 2020 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants