Avoid duplicate offline pack completion notifications #421
Conversation
…completed pack download
1ec5
changed the title
| deinit { | ||
| // Remove offline pack observers. | ||
| print("Removing offline pack notification observers") | ||
| NotificationCenter.default.removeObserver(self) |
There was a problem hiding this comment.
It’s still important to clean up observations when deinitializing (or when the view controller is about to disappear, depending). The application may allow the user to navigate away from the offline pack–downloading view controller before the download completes. If that happens, the view controller shouldn’t leak memory due to a lingering observation.
| NotificationCenter.default.removeObserver(self, name: NSNotification.Name.MGLOfflinePackProgressChanged, object: nil) | ||
| NotificationCenter.default.removeObserver(self, name: NSNotification.Name.MGLOfflinePackError, object: nil) | ||
| NotificationCenter.default.removeObserver(self, name: NSNotification.Name.MGLOfflinePackMaximumMapboxTilesReached, object: nil) |
There was a problem hiding this comment.
Each of these observations would be worth removing during deinitialization too. Similar to what you did with the calls to addObserver(_:selector:name:object:), you can factor these calls to removeObserver(_:name:object:) into a separate method for consistency.
There was a problem hiding this comment.
oddly enough, changing completedResources == expectedResources to pack.state == .complete resolves the duplicate notification in this example
Fixes #419