Enable Class<>::Find() for Array objects #9
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class<>::Find
currently calls the tag'sName()
method, which means that it's currently quite ugly to retrieve an array class (e.g.Object[]
) since you'd have to specify[Ljava/util/Object;
as theName()
of the tag.Instead, we could implement a
Name()
function onArray<Object<...>>
specialization, so you could dojni::Class<jni::Array<jni::Object<...>>>::Find(env)
.