-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the naming convention for alternate icons #296
Comments
@nickidlugash |
Closed
Closed
@nickidlugash |
@natslaughter I think we should move forward with this for now, and can revisit later if necessary based on user feedback. Let's get this documented in the guidelines first though before we close the ticket. |
tristen
changed the title
Alternate icons for the same concept
Document the naming convention for alternate icons
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For some Maki icon concepts, it makes sense to include alternative icons. We can append
alt1
etc to their file names (after the maki name, before the size).The original icon (aka the one without "alt" in the name) should be the icon that the Mapbox Streets style uses for that Mapbox Streets data Maki value. In most cases, this is the icon users will want to use in conjunction with the Mapbox Streets data. If they want to use an alternative icon with our data, they can just rename the icons in their project accordingly.
We have two icons in our latest batch that could be renamed using this system:
landmark-{size}
-->landmark-alt1-{size}
(and bring back the originallandmark-{size}
that was overridden)central-building-{size}
-->building-alt1-{size}
. I think the name "central building" is too specific – this icon could be used to represent any kind of building.^ @natslaughter what do you think of these suggested updates?
/cc @samanpwbb
The text was updated successfully, but these errors were encountered: