Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the naming convention for alternate icons #296

Closed
nickidlugash opened this issue Sep 19, 2016 · 4 comments
Closed

Document the naming convention for alternate icons #296

nickidlugash opened this issue Sep 19, 2016 · 4 comments

Comments

@nickidlugash
Copy link

For some Maki icon concepts, it makes sense to include alternative icons. We can append alt1 etc to their file names (after the maki name, before the size).

The original icon (aka the one without "alt" in the name) should be the icon that the Mapbox Streets style uses for that Mapbox Streets data Maki value. In most cases, this is the icon users will want to use in conjunction with the Mapbox Streets data. If they want to use an alternative icon with our data, they can just rename the icons in their project accordingly.

We have two icons in our latest batch that could be renamed using this system:

  • landmark-{size} --> landmark-alt1-{size} (and bring back the original landmark-{size} that was overridden)
  • central-building-{size} --> building-alt1-{size}. I think the name "central building" is too specific – this icon could be used to represent any kind of building.

^ @natslaughter what do you think of these suggested updates?

/cc @samanpwbb

@natslaughter
Copy link
Contributor

@nickidlugash
I think this is a logical approach to this issue.

@natslaughter
Copy link
Contributor

@nickidlugash
Do you feel that the icon-name-alt1-15 technique works?
If so, can we close this issue?

@nickidlugash
Copy link
Author

@natslaughter I think we should move forward with this for now, and can revisit later if necessary based on user feedback.

Let's get this documented in the guidelines first though before we close the ticket.

@tristen tristen changed the title Alternate icons for the same concept Document the naming convention for alternate icons Jun 4, 2021
@tristen tristen closed this as completed Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants