Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entrance-alt1 icon #317

Closed
aparlato opened this issue Dec 9, 2016 · 18 comments
Closed

entrance-alt1 icon #317

aparlato opened this issue Dec 9, 2016 · 18 comments
Assignees

Comments

@aparlato
Copy link
Contributor

aparlato commented Dec 9, 2016

For id-support from #270

Entrance on taginfo

reference to Maki 1 icon for entrance

reference to current entrance icon

We need an entrance icon for buildings, parking garages, etc. instead of only escalators for subway entrances.

icon for entrance: (key)

cc @nickidlugash

@aparlato aparlato self-assigned this Dec 9, 2016
@bhousel bhousel mentioned this issue Dec 9, 2016
22 tasks
@nickidlugash
Copy link

@aparlato We already have an entrance icon. Let's test out the alternate icon naming convention here? /cc @natslaughter

@aparlato aparlato changed the title entrance icon for Maki 2 entrance-alt1 icon for Maki 2 Dec 12, 2016
@aparlato aparlato changed the title entrance-alt1 icon for Maki 2 entrance-alt1 icon Dec 12, 2016
@aparlato
Copy link
Contributor Author

First draft

11:
image

15:
image

@natslaughter
Copy link
Contributor

@aparlato
Looks good. Not to send us down a rabbit hole, but I wonder if there is another style of arrow we could use. The one you used is probably best as it reads well.

I noticed that your rounded corners are separate circles:

screen shot 2016-12-14 at 8 59 16 am

Eventually we will need the icon to be a single path, but the circles are also causing the corners to be a little jagged:

screen shot 2016-12-14 at 8 57 36 am

And just a minor detail:

screen shot 2016-12-14 at 8 57 56 am

@nickidlugash
Copy link

@aparlato @natslaughter none of our icons use perspective (this is in our design guidelines). Do you two feel like this icon can justify the deviation?

@natslaughter
Copy link
Contributor

@aparlato
@nickidlugash has a good point.
I've seen this icon in 2D where the door is simply a rectangle with the same opening for the arrow.
Want to try that?

@aparlato
Copy link
Contributor Author

Draft 2

11:
image
image

15:
image
image

@natslaughter
Copy link
Contributor

@aparlato
The 2d approach is working a lot better.

I think it would be nice to use a more contemporary arrow like this, but with a slightly longer stem:
image

Regarding the door, I like the thinner line weight, but the end nubs need to be the same:

screen shot 2016-12-15 at 10 14 00 am

@aparlato
Copy link
Contributor Author

Draft 3

Sorry about that! the missing round curve was an oversight. Let me know what you think of new and improved arrow.
I tried to go a little thicker with the 15 arrow, but found it awkward so I brought it back to the same line thickness as 11 but all lines longer.

Also do you think I should keep the rounded corners on the rectangle considering the new arrow? Or I was thinking of keeping the rounded corners, but getting rid of the rounded line caps.

11:
image
image

15:
image
image

@natslaughter
Copy link
Contributor

@aparlato
Thanks for trying that out, but I'm not seeing much difference at 100% scale, and we should probably stick to the rounded ends. Sorry.

@aparlato
Copy link
Contributor Author

Draft 4

@natslaughter all good, here's a better version of the rounded arrow.

11:
image
image

15:
image
image

@aparlato
Copy link
Contributor Author

Draft 5

11:
image
image

15:
image
image

@natslaughter
Copy link
Contributor

@aparlato
the 11 pixel icon is looking sharp.

@natslaughter
Copy link
Contributor

@aparlato
I think the main issue is the door proportions. The 11-pixel door is very square, whereas the 15-pixel is very rectangular. This might take some finessing on your part, but try extending the 15-pixel's horizontal door elements a few pixels further to see if that helps it get more square.
Here are some additional comments:

screen shot 2016-12-16 at 3 05 55 pm

screen shot 2016-12-16 at 3 08 42 pm

@aparlato
Copy link
Contributor Author

Draft 6

I think this looks pretty good. Two possible concerns:

  1. By shortening the arrow's pointed end's strokes, it has begun to feel more like a solid triangle element at the end of a stick rather than a stick arrow at scale.
  2. I'm not sure whether to keep the ends of the open rectangle in the 15px coming around the last corner or terminating before turning towards each other like in the 11px version.

Thoughts on these concerns?

11:
image
image

15:
image
image

@natslaughter
Copy link
Contributor

@aparlato
I see what you're saying about the 11-pixel arrow looking more like a solid triangle: my bad.
Please revert to the 11-pixel arrow ends extending into the adjacent left pixels.

@aparlato
Copy link
Contributor Author

@natslaughter Can do. In the meantime, how do we feel about the 15px more open without the last corners rounding towards each other to better mimic the 11px?

15:
image
image

@aparlato
Copy link
Contributor Author

11px reverted

image
image

The arrow's end triangle strokes have been re-extended and the point brought back some to allow a pixel of white space between all the arrow's lines for clairty.
image

@aparlato
Copy link
Contributor Author

This was done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants