Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity with maki1 for iD #270

Closed
22 tasks done
bhousel opened this issue May 24, 2016 · 8 comments
Closed
22 tasks done

Parity with maki1 for iD #270

bhousel opened this issue May 24, 2016 · 8 comments
Assignees

Comments

@bhousel
Copy link
Contributor

bhousel commented May 24, 2016

This is more FYI, and not necessarily a to-do. I chatted with @natslaughter today, here is a generated list of icons that iD is using from maki1 that are not in maki2:

Also I did notice some icons have changed semantically and we would need to change how we use them:

  • barrier (we were using prison for all kinds of gate-like things, barriers, fences, etc) barrier icon #316
  • fence (similar to barrier although specifically for fence-like barriers) fence icon #324
  • entrance-alt1 (we were using it for entrances to buildings / parking garages, not just escalators) entrance-alt1 icon #317

Also if we're doing requests, we could use

Thanks!! Love the new maki2 icons! 👍

cc @kepta
cc @nickidlugash

@aparlato
Copy link
Contributor

aparlato commented Dec 9, 2016

I made a couple of minor changes to clarify the needs from the above list. Specifically I changed prison to gate and made the note reference that we were using prison for this previously. I am also making minor changes to meet our naming convention.

@nickidlugash
Copy link

@aparlato @natslaughter should we consider this request for a horse-riding icon as part of this push?

@aparlato
Copy link
Contributor

^ just started this (horse riding icon) and will work on it tomorrow. I'm in favor of adding it to the mix.

image

@natslaughter
Copy link
Contributor

@bhousel
Here is where the icons stand as of today. @samanpwbb, @nickidlugash, @aparlato and I met yesterday and came up with a plan to finish this up and incorporate them into the Maki catalogue next Monday or Tuesday.

Icon 11 x 11 15 x 15
Logging logging-11 loggin-15
Barrier barrier-11 barrier-15
Park-alt1 park-alt1-11 park-alt1-15
Entrance-alt1 entrance-alt1-11 entrance-alt1-15
Landuse landuse-11 landuse-15
Mobile-phone mobile-phone-11 mobile-phone-15
Emergency-phone emergency-phone-11 emergency-phone-15
City city-11 city-15
Town town-11 town-15
Village village-11 village-15
Defibrillator (bolt) defibrillator-bolt_11 defibrillator-bolt_15
Defibrillator (ekg) defibrillator-ekg_11 defibrillator-ekg_15
Slaughterhouse slaughterhouse_11 slaughterhouse_15
Horse-riding horse-riding-11 horse-riding-15

@natslaughter
Copy link
Contributor

natslaughter commented Dec 21, 2016

@bhousel
Thanks for letting us know about the 'natural/landcover' icon need.
I'm going to suggest we hold off for this round of icons, since we are finished with the icons and are merging them into Maki today.
Let's treat this as an individual icon request #328.

@aparlato
Copy link
Contributor

aparlato commented Jan 9, 2017

Closing #270

Released all these icons 👍

@aparlato aparlato closed this as completed Jan 9, 2017
@bhousel
Copy link
Contributor Author

bhousel commented Jan 10, 2017

Thank you for all your work on this!

@bhousel
Copy link
Contributor Author

bhousel commented Jan 13, 2017

cc @ajithranka who is working on the maki migration for iD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants