This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Adding example of using TurfTransformation#circle to create visual ring #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Inspired by this, which I saw online recently:
|
langsmith
force-pushed
the
ls-hollow-circle-example
branch
2 times, most recently
from
9686b73 to
4d81399
Compare
langsmith
force-pushed
the
ls-hollow-circle-example
branch
2 times, most recently
from
a4da1a5 to
92f9512
Compare
langsmith
force-pushed
the
ls-hollow-circle-example
branch
from
92f9512 to
6a3d650
Compare
This example is fantastic, @langsmith! But I agree that it's distinct enough from #1032 that they shouldn't be mutually exclusive. |
|
This BART map is a good example of why a ring would be drawn
|
tobrun
approved these changes
May 14, 2019
|
|
||
| private void moveRing(Point centerPoint) { | ||
| if (mapboxMap.getStyle() != null) { | ||
| Style style = mapboxMap.getStyle(); |
There was a problem hiding this comment.
just as fyi, alternatively to avoid nullability of a style you can use mapboxMap.getStyle(OnStyleLoadedCallback) this will give you a hook where style will always be non null.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds an example using
TurfTransformation#circle()andTurfMeta.coordAll()to create a ring around a centerPointcoordinate.TurfTransformation#circle()is used twice. The first time is to get the coordinates for theFillLayerPolygon's outer ring coordinates. The second time is to get the inner ring coordinates. The finalPolygonis then constructed with the outer and innerLineStringobjects.This pr is related to #1032 but I'm not sure whether it resolves it. Might be good to add a more basic
TurfTransformation#circle()example (i.e. no hollow ring) to this demo app.