Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Polygon hole layer below null check #1145

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Polygon hole layer below null check #1145

merged 1 commit into from
Jul 23, 2019

Conversation

langsmith
Copy link
Contributor

@langsmith langsmith commented Jul 22, 2019 •
edited
Loading

This pr addresses https://github.com/mapbox/android-docs/issues/1003 and resolves #1138 by refactoring PolygonHolesActivity to add a null check for a map layer. If the road-number-shield layer is present, place the polygon hole FillLayer below the road-number-shield layer. If not, the FillLayer is just added to the map.

road-number-shield is a default layer in Mapbox Streets Style.MAPBOX_STREETS

@langsmith langsmith requested a review from LukasPaczos July 22, 2019 20:40
@langsmith langsmith self-assigned this Jul 22, 2019
LukasPaczos
LukasPaczos approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢
The resolves links to itself, probably should close something else :)

@langsmith
Copy link
Contributor Author

fixed to #1138

@langsmith langsmith merged commit 18d877b into master Jul 23, 2019
@langsmith langsmith deleted the ls-polygon-holes-layer-below-check branch July 23, 2019 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@langsmith langsmith

Labels
✓ ready for review 👍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust layer name for addLayerBelow in polygon holes example
2 participants
@langsmith @LukasPaczos