Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Hillshading example #621

Merged
merged 3 commits into from
Apr 18, 2018
Merged

Hillshading example #621

merged 3 commits into from
Apr 18, 2018

Conversation

langsmith
Copy link
Contributor

@langsmith langsmith commented Feb 8, 2018

Don't merge until demo app uses 6.x of the Maps SDK

Resolves #609 by adding a very basic example of using a HillshadeLayer layer.

Will make cooler hillshade examples in separate future prs

ezgif com-crop

@mollymerp
Copy link

awesome! thanks @langsmith

shading and camera tweaks

Refactor

manifest tweak

final tweaks
@langsmith
Copy link
Contributor Author

Would love 👀 when you get a chance @cammace or @osana 🙇

Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small change.

}

@Override
public void onCameraIdle() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for implementing this method? If so include a No-Op comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slipped past me. Removed.

@langsmith
Copy link
Contributor Author

Ok, should be good to go @cammace

@langsmith langsmith merged commit d87a016 into master Apr 18, 2018
@langsmith langsmith deleted the ls-hillshade-example branch April 18, 2018 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants