Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outlier tracepoint crashes conversion from match to route #305

Closed
1ec5 opened this issue Oct 29, 2018 · 1 comment
Closed

Outlier tracepoint crashes conversion from match to route #305

1ec5 opened this issue Oct 29, 2018 · 1 comment
Labels
bug

Comments

@1ec5
Copy link
Contributor

1ec5 commented Oct 29, 2018

According to the Map Matching API documentation, if a tracepoint is considered an outlier, it is represented in the response’s tracepoints array as a null. However, the following code assumes tracepoints is a homogeneous array of dictionaries with no nulls, so any outlier will result in a crash:

https://github.com/mapbox/MapboxDirections.swift/blob/ccadf0af2c64036da07e7e5425c3d9ecdd560454/MapboxDirections/Match/MBMatchOptions.swift#L137

/cc @frederoni @JThramer
@1ec5 1ec5 added the bug label Oct 29, 2018
@1ec5
Copy link
Contributor Author

1ec5 commented Dec 28, 2019

#393 fixes the crash.

@1ec5 1ec5 closed this as completed Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@1ec5