Objective-C removal followups for navigation SDK compatibility #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Dec 19, 2019
| public var error: String? | ||
| public let uuid: String? | ||
| public let routes: [Route]? | ||
| public let waypoints: [Waypoint]? |
There was a problem hiding this comment.
This change requires us to address all of #391. Are you sure we should do so before integrating the navigation SDK with the first round of Swifitification in this library?
4 tasks
1ec5
changed the title
1ec5
force-pushed
the
jerrad/delenda-duet-dependencies
branch
from
38ee296
to
895971c
Compare
1ec5
approved these changes
Dec 25, 2019
Also reshuffled RouteStep a bit.
Also made approachIndex and outletIndex optional instead of setting them to −1 at the route endpoints.
Splitting an empty string results in an array containing an empty string.
1ec5
force-pushed
the
jerrad/delenda-duet-dependencies
branch
from
895971c
to
e556d6e
Compare
1ec5
added
backwards incompatible
This was referenced Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix some loose ends found while working on mapbox/mapbox-navigation-ios#2275. It is a work-in-progress.
/cc @mapbox/navigation-ios