Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux #484

Closed
2 tasks done
1ec5 opened this issue Nov 3, 2020 · 3 comments · Fixed by #488
Closed
2 tasks done

Linux #484

1ec5 opened this issue Nov 3, 2020 · 3 comments · Fixed by #488
Assignees
Labels
build improvement Improvement for an existing feature.

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 3, 2020

This library should run on all of Swift’s officially supported platforms, including Linux. Linux support should be practical because this library has no real UI dependency, other than a few conveniences around default pixel densities that are easy to stub out.

Linux support will enable the command line utility in #451 to be run in the same development environment that Valhalla developers use, making it more likely that any regressions introduced in the Mapbox Directions API will be quickly caught by the server-side teams before production deployment.

#366 attempted to add Linux and SPM support and rename the library from MapboxDirections.swift to MapboxDirections all at the same time, but it got bogged down by the need to support Objective-C. Since then, we added SPM support in #362, removed Objective-C compatibility in #382, and renamed the library in #400. #366 may be of interest for a few build-related files, but most of its changes are no longer necessary. The one remaining blocker is that Polyline doesn’t support Linux yet: raphaelmor/Polyline#55.

/cc @mapbox/navigation-ios @frederoni

@1ec5 1ec5 added improvement Improvement for an existing feature. build labels Nov 3, 2020
@1ec5 1ec5 added this to the v1.1.0 milestone Nov 3, 2020
@1ec5 1ec5 modified the milestones: v1.1.0, v1.2.0 Nov 3, 2020
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 3, 2020

This issue is on the v1.2.0 milestone, but I think we’ll need to take care of raphaelmor/Polyline#55 within the v1.1 timeframe so that it goes into the semver-major release of Polyline that we’ll already teed up to put out.

@1ec5
Copy link
Contributor Author

1ec5 commented Nov 5, 2020

Polyline v5.0.0 has been released: raphaelmor/Polyline#65 (comment). Now we need to upgrade this library to it and implement the rest of the build configuration changes for Linux support.

@1ec5 1ec5 self-assigned this Nov 5, 2020
This was referenced Nov 5, 2020
@1ec5 1ec5 closed this as completed in #488 Nov 6, 2020
@1ec5
Copy link
Contributor Author

1ec5 commented Nov 10, 2020

#494 tracks the fact that most of the unit tests aren’t running on Linux (or on any platform using SPM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build improvement Improvement for an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant