Add support for Linux #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
force-pushed
the
fred/spm
branch
4 times, most recently
from
658a406
to
619fcd8
Compare
frederoni
force-pushed
the
fred/spm
branch
3 times, most recently
from
2265f23
to
f780f54
Compare
|
Out of curiosity, what’s left before this PR could be ready for review? |
|
The majority of the changes here is to avoid method dispatching on Linux. If or when we drop support for Objective-C, the necessary changes to support Linux would be a minor shim for CoreLocation data types, roughly 60 lines of code. Another blocker is raphaelmor/Polyline#55 It will be easier to start this PR from scratch so I'm closing this for now. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is targeting the
fred/spmbranchOutlined support for Linux.