Attributes #118

bsudekum · 2017-03-21T20:37:18Z

Adds optional query param annotation. This is an array of annotation types, allowed enum values: .distance, .duration, .speed, .node.

Still need to add documentation.

/cc @1ec5

1ec5 · 2017-03-22T00:14:50Z

MapboxDirections/MBAnnotation.swift

+//  MapboxDirections
+//
+//  Created by Bobby Sudekum on 3/20/17.
+//  Copyright © 2017 Mapbox. All rights reserved.


Omit this file header comment. This is a permissively licensed project under version control, so the comment adds little value.

1ec5 · 2017-03-22T00:22:42Z

MapboxDirections/MBRouteLeg.swift

@@ -98,6 +130,9 @@ open class RouteLeg: NSObject, NSSecureCoding {
     */
    open let steps: [RouteStep]

+
+    open let annotation: [AnnotationType:[Any]]?


Annotation is a poor name for this information for the following reasons:

It's a collection of data, so a plural word is preferable.

The Mapbox iOS and macOS SDKs already have a concept of annotations (for consistency with MapKit) that's completely different: markers and overlays on a map. Google Maps calls them markers, but developers are required to use the Mapbox SDKs with this library anyways.

The term doesn't say anything about the relationship between the route leg and the information indicated by the property.

Some suggestions:

nodeAttributes (so far only for the nodeIdentifiers key) and segmentAttributes (for the other keys)

attributes

userInfo – Although this may sound strange, it's consistent with Cocoa APIs like NSError and NSNotification.

With a split between "node attributes" and "segment attributes", we'll eventually be able to distribute the attribute values among each step (while still retaining the full, leg-level attribute structure as an option).

A little trivia: "segment" used to be a primitive data type in OpenStreetMap back in the day.

1ec5 · 2017-03-22T00:35:13Z

MapboxDirections/MBAnnotation.swift

+
+    case duration
+
+    case nodes


(I'm going to call annotation types "attributes" for the rest of this review; see below.)

Let's call this openStreetMapNodeIdentifier, similar to how MapboxGeocoder.swift has a wikidataItemIdentifier. If on the other hand we expect the same underlying string to be used for non-OSM data sources, nodeIdentifier would be better. (I'd like to avoid using "node" by itself, because perhaps we may associate more attributes with OSM nodes in the future.)

1ec5 · 2017-03-22T00:36:43Z

MapboxDirections/MBAnnotation.swift

+@objc(AnnotationType)
+public enum AnnotationType: Int, CustomStringConvertible {
+
+    case congestion


"Congestion" is a strange word to use on its own, since it's uncountable. (Imagine talking about "congestions".) Let's call it congestionLevel.

1ec5 · 2017-03-22T00:38:17Z

MapboxDirections/MBRouteLeg.swift

+
+        var annotation: Annotation = [:]
+        if json["annotation"] != nil {
+            let rawAnnoation = json["annotation"] as! [String: Any]


s/annoation/annotation/

1ec5 · 2017-03-22T00:39:28Z

MapboxDirections/MBRouteLeg.swift

+        if json["annotation"] != nil {
+            let rawAnnoation = json["annotation"] as! [String: Any]
+            if rawAnnoation["congestion"] != nil {
+                annotation[.congestion] = (rawAnnoation["congestion"] as! [String]).map { CongestionLevel(description: $0) ?? .unknown}


To avoid repeating yourself, use an if let … as? … above`.

1ec5 · 2017-03-22T00:40:17Z

MapboxDirections/MBRouteOptions.swift

@@ -256,6 +258,15 @@ open class RouteOptions: NSObject {
            params.append(URLQueryItem(name: "radiuses", value: accuracies))
        }

+
+        if annotation.count > 0 {


Nit: !annotation.isEmpty

1ec5 · 2017-03-22T00:41:12Z

MapboxDirections/MBRouteOptions.swift

@@ -211,6 +211,8 @@ open class RouteOptions: NSObject {
     */
    open var routeShapeResolution = RouteShapeResolution.low

+    open var annotation: [AnnotationType] = []


attributes

1ec5 · 2017-03-22T00:42:14Z

MapboxDirections/MBRouteLeg.swift

@@ -40,6 +68,9 @@ open class RouteLeg: NSObject, NSSecureCoding {
        }
        source = decodedSource

+
+        annotation = nil


The encode method encodes the attribute data, so the decode method should decode it.

1ec5 · 2017-03-22T00:44:55Z

MapboxDirections/MBAnnotation.swift

+
+    case distance
+
+    case duration


"Durations" can indicate lots of things. Let's call this expectedTravelTime, for consistency with the expectedTravelTime property of RouteLeg and RouteStep.

bsudekum · 2017-03-31T16:52:19Z

@1ec5 updated with feedback

1ec5 · 2017-04-01T22:44:57Z

MapboxDirections.xcodeproj/project.pbxproj

@@ -15,6 +15,8 @@
 		358D48871E2EAB4500F32A65 /* MBRouteOptions.m in Sources */ = {isa = PBXBuildFile; fileRef = 358D48851E2EAB4500F32A65 /* MBRouteOptions.m */; };
 		358D48881E2EAB4500F32A65 /* MBRouteOptions.m in Sources */ = {isa = PBXBuildFile; fileRef = 358D48851E2EAB4500F32A65 /* MBRouteOptions.m */; };
 		358D48891E2EAB4500F32A65 /* MBRouteOptions.m in Sources */ = {isa = PBXBuildFile; fileRef = 358D48851E2EAB4500F32A65 /* MBRouteOptions.m */; };
+		C51538CC1E807FF00093FF3E /* MBAnnotation.swift in Sources */ = {isa = PBXBuildFile; fileRef = C51538CB1E807FF00093FF3E /* MBAnnotation.swift */; };


This file needs to be added to all four framework targets. Because it’s only in the iOS framework target, macOS, tvOS, and watchOS builds are failing with numerous errors, starting with:

▸ Compiling MBRouteLeg.swift ❌ /Users/vagrant/git/MapboxDirections/MBRouteLeg.swift:11:36: use of undeclared type 'SegmentAttribute' typealias SegmentAttributes = [SegmentAttribute:[Any]] ^~~~~~~~~~~~~~~~ ❌ /Users/vagrant/git/MapboxDirections/MBRouteLeg.swift:129:34: use of undeclared type 'SegmentAttribute' open let segmentAttributes: [SegmentAttribute:[Any]]? ^~~~~~~~~~~~~~~~ ❌ /Users/vagrant/git/MapboxDirections/MBRouteLeg.swift:173:14: cannot invoke 'RouteLegV4.init' with an argument list of type '(steps: [RouteStepV4], json: JSONDictionary, source: Waypoint, destination: Waypoint, profileIdentifier: MBDirectionsProfileIdentifier)' self.init(steps: steps, json: json, source: source, destination: destination, profileIdentifier: profileIdentifier) ^

1ec5 · 2017-04-01T22:45:20Z

MapboxDirections.xcodeproj/project.pbxproj

@@ -15,6 +15,8 @@
 		358D48871E2EAB4500F32A65 /* MBRouteOptions.m in Sources */ = {isa = PBXBuildFile; fileRef = 358D48851E2EAB4500F32A65 /* MBRouteOptions.m */; };
 		358D48881E2EAB4500F32A65 /* MBRouteOptions.m in Sources */ = {isa = PBXBuildFile; fileRef = 358D48851E2EAB4500F32A65 /* MBRouteOptions.m */; };
 		358D48891E2EAB4500F32A65 /* MBRouteOptions.m in Sources */ = {isa = PBXBuildFile; fileRef = 358D48851E2EAB4500F32A65 /* MBRouteOptions.m */; };
+		C51538CC1E807FF00093FF3E /* MBAnnotation.swift in Sources */ = {isa = PBXBuildFile; fileRef = C51538CB1E807FF00093FF3E /* MBAnnotation.swift */; };
+		C5247D711E818A24004B6154 /* AnnotationTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = C5247D701E818A24004B6154 /* AnnotationTests.swift */; };


Likewise, this file needs to be added to all four unit test targets.

1ec5 · 2017-04-01T22:46:14Z

MapboxDirections/MBAnnotation.swift

@@ -0,0 +1,45 @@
+import Foundation
+
+@objc(AnnotationType)


This type needs a documentation comment.

1ec5 · 2017-04-01T22:46:24Z

MapboxDirections/MBAnnotation.swift

+@objc(AnnotationType)
+public enum SegmentAttribute: Int, CustomStringConvertible {
+
+    case distance


Each of these cases needs a documentation comment.

1ec5 · 2017-04-01T22:47:17Z

MapboxDirections/MBAnnotation.swift

+import Foundation
+
+@objc(AnnotationType)
+public enum SegmentAttribute: Int, CustomStringConvertible {


This type should be called simply Attribute, because openStreetMapNodeIdentifier is a node attribute, not a segment attribute.

1ec5 · 2017-04-01T22:50:20Z

MapboxDirections/MBRouteLeg.swift

@@ -40,6 +63,9 @@ open class RouteLeg: NSObject, NSSecureCoding {
        }
        source = decodedSource

+
+        segmentAttributes = nil


#118 (comment)

1ec5 · 2017-04-01T22:50:47Z

MapboxDirections/MBRouteOptions.swift

@@ -256,6 +258,16 @@ open class RouteOptions: NSObject {
            params.append(URLQueryItem(name: "radiuses", value: accuracies))
        }

+
+        if segmentAttributes.count > 0 {


#118 (comment)

1ec5 · 2017-04-01T22:51:15Z

MapboxDirections/MBRouteOptions.swift

+
+        if segmentAttributes.count > 0 {
+            let segmentAttributesStrings = segmentAttributes.map {
+                $0.description


String(describing: $0)

1ec5 · 2017-04-01T22:52:42Z

MapboxDirectionsTests/AnnotationTests.swift

+        XCTAssertNotNil(annotation[.distance])
+        XCTAssertNotNil(annotation[.expectedTravelTime])
+        XCTAssertNotNil(annotation[.openStreetMapNodeIdentifier])
+        XCTAssertNotNil(annotation[.speed])


These tests should also check specific attribute values.

1ec5 · 2017-04-01T22:53:09Z

MapboxDirectionsTests/AnnotationTests.swift

+        XCTAssertNotNil(annotation[.openStreetMapNodeIdentifier])
+        XCTAssertNotNil(annotation[.speed])
+
+        let nodes = annotation[.openStreetMapNodeIdentifier]!.count


Check that there are the right number of node identifier attributes.

1ec5

Some bad news about Objective-C bridging, but it turns out that addressing these issues will make the API make more sense even in Swift.

1ec5 · 2017-04-03T23:54:11Z

MapboxDirections/MBRouteLeg.swift

@@ -59,6 +84,10 @@ open class RouteLeg: NSObject, NSSecureCoding {
            return nil
        }
        profileIdentifier = MBDirectionsProfileIdentifier(rawValue: decodedProfileIdentifier)
+
+        segmentAttributes = decoder.decodeObject(of: [NSArray.self], forKey: "segmentAttributes") as? [Attribute: [Any]] ?? [:]


The code below encodes the object as a dictionary. This line tries to decode the object as an NSArray, which will produce nil. Even if it were to somehow produce an array, this line then casts the array to a dictionary, which will produce nil.

The class you pass into decodeObject(of:forKey:) should match the class of the object you pass into encode(_:forKey:) below.

1ec5 · 2017-04-03T23:57:52Z

MapboxDirections/MBRouteOptions.swift

@@ -211,6 +211,10 @@ open class RouteOptions: NSObject {
     */
    open var routeShapeResolution = RouteShapeResolution.low

+    open var segmentAttributes: [Attribute] = []


An array of enum values won't bridge to Objective-C. Besides, we want an OptionSet for this particular property, since it doesn't make sense to specify .speeds twice, for example. I think we're going to need something similar to LaneIndication – an Objective-C NS_OPTION instead of this Swift enumeration.

1ec5 · 2017-04-04T00:04:37Z

MapboxDirections/MBRouteLeg.swift

@@ -98,6 +129,11 @@ open class RouteLeg: NSObject, NSSecureCoding {
     */
    open let steps: [RouteStep]

+
+    open let segmentAttributes: [Attribute:[Any]]?


This property won't bridge to Objective-C, because NSDictionary's keys need to be objects, not enumeration values. (Option sets won't bridge either.) We'll probably want to use an Objective-C string enumeration (NS_STRING_ENUM) instead of the Swift enumeration. It would be separate from the option set used in RouteOptions.

If that's too much trouble, RouteLeg could have a separate property for each attribute. For example, segmentSpeeds would be of type [CLLocationSpeed]. That would be pretty clean, but I don't know what the story will be for any unsupported attributes we get back from the API.

1ec5 · 2017-04-04T18:57:09Z

MapboxDirections/MBAttribute.h

+
+    MBAttributeSpeed = (1 << 4),
+
+    MBAttributeAll = 0x0ffffUL


We probably don’t need an “all” option for attributes.

bsudekum · 2017-04-05T19:00:54Z

@1ec5 this is ready for another round of 👀

1ec5

This is coming together nicely. The tests are looking good too. Don’t forget to add documentation for any new types and properties.

1ec5 · 2017-04-06T22:31:04Z

Cartfile.resolved

-binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "3.4.2"
-github "AliSoftware/OHHTTPStubs" "57feceaabf333e72b2c637dfba6c13a7a5c49619"
+binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "3.5.0"
+github "AliSoftware/OHHTTPStubs" "f90c2bb0fb882e43761ab963ca8869d349d2c6e3"


This is fine, but in the future, let’s split out any changes that occur due to running carthage update into separate PRs, so that we can narrow down any regressions they cause. If you just need to get set up, use carthage bootstrap instead.

I'll revert this

1ec5 · 2017-04-06T22:33:00Z

MapboxDirections/MBRouteLeg.swift

-        self.segmentAttributes = segmentAttributes
-        self.nodeAttributes = nodeAttributes
+
+        var segmentDistances: [CLLocationDistance]? = nil


Nit: an optional is nil by default; no need to set it to nil.

1ec5 · 2017-04-06T22:38:22Z

MapboxDirections/MBRouteLeg.swift


-    open let nodeAttributes: [Attribute:[Any]]?
+    open let nodeOpenStreetMapNodeIdentifiers: [Int]?


To avoid overflow, OSM node IDs must be stored as 64-bit integers. Int can be either 32-bit or 64-bit according to the device’s architecture. To be on the safe side and to clarify our intent, use Int64.

1ec5 · 2017-04-06T22:40:02Z

MapboxDirections/MBRouteLeg.swift


-    open let nodeAttributes: [Attribute:[Any]]?
+    open let nodeOpenStreetMapNodeIdentifiers: [Int]?


“Node” is in the name twice, unnecessarily: rename this property to openStreetMapNodeIdentifiers.

1ec5 · 2017-04-06T22:41:03Z

MapboxDirections/MBRouteLeg.swift

@@ -129,10 +134,13 @@ open class RouteLeg: NSObject, NSSecureCoding {
     */
    open let steps: [RouteStep]

+    open let segmentDistances: [CLLocationDistance]?
+
+    open let segmentExpectedTravelTimes: [TimeInterval]?


The name of this property makes it sound like a verb, “to segment the expected travel times”. Rename this property to expectedSegmentTravelTimes.

1ec5 · 2017-04-06T22:44:56Z

MapboxDirections/MBRouteOptions.swift

                String(describing: $0)
-            }.joined(separator: ",")
+                }.joined(separator: ",")


Attribute.description is already a comma-separated list, so you can set attributesStrings to String(describing: segmentAttributes + .openStreetMapNodeIdentifier) to get the same effect.

1ec5 · 2017-04-06T22:46:22Z

MapboxDirections/MBRouteOptions.swift

@@ -211,6 +211,10 @@ open class RouteOptions: NSObject {
     */
    open var routeShapeResolution = RouteShapeResolution.low

+    open var segmentAttributes: [Attribute] = []


Now that Attribute is an OptionSet, we no longer need an array of Attributes; a single Attribute can store multiple options.

1ec5 · 2017-04-06T22:46:58Z

MapboxDirections/MBRouteOptions.swift

@@ -211,6 +211,10 @@ open class RouteOptions: NSObject {
     */
    open var routeShapeResolution = RouteShapeResolution.low

+    open var segmentAttributes: [Attribute] = []
+
+    open var nodeAttributes: [Attribute] = []


Compared to the situation in RouteLeg before, there’s no need to distinguish between segment and node attributes in RouteOptions – the two behave exactly the same as far as requesting a route is concerned. A single attributeOptions property will do.

1ec5 · 2017-04-06T22:49:50Z

MapboxDirections/MBAttribute.h

@@ -0,0 +1,10 @@
+typedef NS_OPTIONS(NSUInteger, MBAttribute) {


One more rename! Now that this is an option set instead of a single attribute, rename this type to MBAttributeOptions, so it’s easier to talk about individual attributes versus the whole set of attributes.

bsudekum · 2017-04-07T18:43:55Z

@1ec5 fixed

1ec5

A little more finessing around options, plus documentation, and I think this will be good to go!

1ec5 · 2017-04-08T00:33:49Z

MapboxDirections/MBRouteOptions.swift

@@ -211,6 +211,10 @@ open class RouteOptions: NSObject {
     */
    open var routeShapeResolution = RouteShapeResolution.low

+    open var segmentAttributes: AttributeOptions = []
+
+    open var nodeAttributes: AttributeOptions = []


Combine these two properties into a single attributes property.

bsudekum · 2017-04-09T16:44:14Z

Started documentation in 5c2c5c0

1ec5 · 2017-04-09T16:49:29Z

MapboxDirections/MBAttribute.h

@@ -1,10 +1,17 @@
+/**
+ Attributes are metadata information for a given route. The number of attributes returned will be a direct 1-1 relationship with the route's full geometry. Each type will return an ordered list of requested attributes. For `.distance`, `.expectedTrabelTime`, and `.speed` there will be one less value when compared to the route geometry. This is because these values represent the data on segment between geometry points.


The .distance, .expectedTrabelTime, and .speed attributes have one fewer value than the .openStreetMapNodeIdentifier attribute.

1ec5 · 2017-04-09T17:05:28Z

MapboxDirections/MBAttribute.swift

+     Creates an AttributeOptions from the given description strings.
+     */
+    public init?(description: String) {
+         var scope: AttributeOptions = []


Nit: funky indentation.

1ec5 · 2017-04-09T17:05:57Z

MapboxDirections/MBAttribute.h

+*/
+typedef NS_OPTIONS(NSUInteger, MBAttributeOptions) {
+
+    /// Segment distance.


Distances are measured in meters.

1ec5 · 2017-04-09T17:06:11Z

MapboxDirections/MBAttribute.h

+    // Segment expected travel time in seconds.
+    MBAttributeExpectedTravelTime = (1 << 2),
+
+    // Segment current speed.


Speeds are measured in meters per second.

1ec5 · 2017-04-09T17:07:49Z

MapboxDirections/MBAttribute.h

+    // Segment current speed.
+    MBAttributeSpeed = (1 << 3),
+
+    // Unique OpenStreetMap node.


This option returns unique node identifiers, not the nodes themselves. Link to this OpenStreetMap Wiki article for more information. Also note that this attribute option is added automatically when any of the other attributes are added.

Also note that this attribute option is added automatically when any of the other attributes are added.

This is not true:

Ah, I thought we had baked that logic into RouteOptions, but it seems to have been removed. 👍

1ec5 · 2017-04-09T17:09:45Z

MapboxDirections/MBRouteOptions.swift

@@ -211,6 +211,13 @@ open class RouteOptions: NSObject {
     */
    open var routeShapeResolution = RouteShapeResolution.low

+    /**
+     AttributeOptions for the route. Any combination of `.AttributeOptions` can be specified. 


Remove the extra dot: .AttributeOptions implies that there’s an AttributeOptions.AttributeOptions.

1ec5 · 2017-04-09T17:09:56Z

MapboxDirections/MBRouteOptions.swift

+    /**
+     AttributeOptions for the route. Any combination of `.AttributeOptions` can be specified. 
+
+     The default value of this property is `[]`.


By default, no attribute options are specified.

1ec5 · 2017-04-09T17:10:07Z

MapboxDirections/MBRouteOptions.swift

@@ -211,6 +211,13 @@ open class RouteOptions: NSObject {
     */
    open var routeShapeResolution = RouteShapeResolution.low

+    /**
+     AttributeOptions for the route. Any combination of `.AttributeOptions` can be specified. 
+


Note that this option requires the routeShapeResolution property to be set to .full. (The default is .low.)

Unfortunately, this is not true. This should be ticketed upstream.

Can you elaborate? Do the attributes still work with .low resolution? Do the values make any sense?

If it’s the case that .low resolution yields the same values (which reflect the .full geometry), let’s recommend that the developer set .full to make use of these options.

1ec5 · 2017-04-09T17:11:36Z

MapboxDirections/MBRouteLeg.swift

+    open let expectedSegmentTravelTimes: [TimeInterval]?
+
+    /**
+     An array of current speeds along segment. This value is dynamic and does not represent the speed limit but rather the average speed for a given segment


An array containing the expected average speed (measured in meters per second) between each coordinate in the route leg geometry.

These values are dynamic; rather than speed limits, they account for the road’s classification and/or any traffic congestion (if the profile identifier is set to .automobileAvoidingTraffic).

This property is set if the RouteOptions.attributeOptions property contains .speed.

1ec5 · 2017-04-09T17:18:37Z

MapboxDirections/MBRouteLeg.swift

+    open let segmentSpeeds: [CLLocationSpeed]?
+
+    /**
+     An array of OpenStreetMap nodes.


An array containing OpenStreetMap node identifiers, one for each coordinate along the route geometry.

This property is set if the RouteOptions.attributeOptions property contains .openStreetMapNodeIdentifier.

1ec5 · 2017-04-10T18:46:35Z

MapboxDirections/MBAttribute.h

@@ -0,0 +1,17 @@
+/**
+ Attributes are metadata information for a given route. The number of attributes returned will be a direct 1-1 relationship with the route's full geometry. The .distance, .expectedTrabelTime, and .speed attributes have one fewer value than the .openStreetMapNodeIdentifier attribute.


Typo: s/expectedTrabelTime/expectedTravelTime/

1ec5 · 2017-04-10T18:47:01Z

MapboxDirections/MBAttribute.h

@@ -0,0 +1,17 @@
+/**
+ Attributes are metadata information for a given route. The number of attributes returned will be a direct 1-1 relationship with the route's full geometry. The .distance, .expectedTrabelTime, and .speed attributes have one fewer value than the .openStreetMapNodeIdentifier attribute.


Surround references like .distance in backticks so jazzy can autolink them.

1ec5 · 2017-04-10T18:47:52Z

MapboxDirections/MBAttribute.h

+    // Segment current speed. Speeds are measured in meters per second.
+    MBAttributeSpeed = (1 << 3),
+
+    // Unique node identifiers (https://wiki.openstreetmap.org/wiki/Node)


Use Markdown syntax:

[OpenStreetMap node identifier](https://wiki.openstreetmap.org/wiki/Node).

1ec5 · 2017-04-10T18:48:44Z

MapboxDirections/MBRouteLeg.swift

+    open let segmentSpeeds: [CLLocationSpeed]?
+
+    /**
+     An array containing OpenStreetMap node identifiers (https://wiki.openstreetmap.org/wiki/Node), one for each coordinate along the route geometry.


Use Markdown syntax here too.

bsudekum · 2017-04-10T22:10:30Z

@1ec5 think this is ready to go

1ec5

Whew! Thanks for all the iterations; this looks great.

1ec5 reviewed Mar 22, 2017

View reviewed changes

1ec5 mentioned this pull request Mar 25, 2017

Add course snapping [wip] mapbox/mapbox-navigation-ios#88

Merged

Add annotation option

cb7c55d

bsudekum force-pushed the annotations branch from 2cdea16 to cb7c55d Compare March 31, 2017 00:23

bsudekum added 2 commits March 30, 2017 17:53

Change names

451127c

Update

6dafd1c

1ec5 suggested changes Apr 1, 2017

View reviewed changes

1ec5 changed the title ~~Add annotation option~~ Attributes Apr 1, 2017

1ec5 added the improvement Improvement for an existing feature. label Apr 1, 2017

bsudekum added 2 commits April 3, 2017 10:34

update

c4999fa

add

b57029a

1ec5 reviewed Apr 4, 2017

View reviewed changes

Make obj c compatible

c853026

1ec5 reviewed Apr 4, 2017

View reviewed changes

bsudekum and others added 6 commits April 4, 2017 11:58

remove all

4f3c11e

update options

d284d6d

update

0984d9e

Fix test

f39c10c

update cartfile

6b13c53

Decode

8fb56c4

1ec5 reviewed Apr 6, 2017

View reviewed changes

Bobby Sudekum added 2 commits April 7, 2017 11:21

more updates

062ac5e

fix

cc5cfc1

1ec5 reviewed Apr 8, 2017

View reviewed changes

1ec5 mentioned this pull request Apr 9, 2017

Add support for route leg annotations #114

Closed

Bobby Sudekum added 2 commits April 9, 2017 09:19

Combine

60141aa

document

5c2c5c0

1ec5 reviewed Apr 9, 2017

View reviewed changes

fix

28dbf64

1ec5 reviewed Apr 10, 2017

View reviewed changes

updates

80157d2

1ec5 approved these changes Apr 10, 2017

View reviewed changes

bsudekum merged commit a962094 into master Apr 10, 2017

bsudekum deleted the annotations branch April 10, 2017 22:29

1ec5 mentioned this pull request Apr 20, 2018

Remove AttributeOptions.openStreetMapNodeIdentifier #270

Closed

1ec5 mentioned this pull request Jul 19, 2022

Replace AttributeOptions with more extensible type #718

Open


		open let nodeAttributes: [Attribute:[Any]]?
		open let nodeOpenStreetMapNodeIdentifiers: [Int]?

		@@ -0,0 +1,10 @@
		typedef NS_OPTIONS(NSUInteger, MBAttribute) {

		@@ -1,10 +1,17 @@
		/**
		Attributes are metadata information for a given route. The number of attributes returned will be a direct 1-1 relationship with the route's full geometry. Each type will return an ordered list of requested attributes. For `.distance`, `.expectedTrabelTime`, and `.speed` there will be one less value when compared to the route geometry. This is because these values represent the data on segment between geometry points.

		@@ -0,0 +1,17 @@
		/**
		Attributes are metadata information for a given route. The number of attributes returned will be a direct 1-1 relationship with the route's full geometry. The .distance, .expectedTrabelTime, and .speed attributes have one fewer value than the .openStreetMapNodeIdentifier attribute.

Attributes #118

Attributes #118

Conversation

bsudekum commented Mar 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Mar 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Apr 5, 2017

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Apr 7, 2017

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Apr 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Apr 10, 2017

1ec5 left a comment

Choose a reason for hiding this comment

bsudekum commented Mar 21, 2017 •

edited

Loading