Fix swift 3.1 warnings #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Mar 30, 2017
MapboxDirections/MBRouteStep.swift
Outdated
| @@ -557,7 +557,7 @@ open class RouteStep: NSObject, NSSecureCoding { | |||
| return nil | |||
| } | |||
| maneuverType = ManeuverType(description: maneuverTypeDescription) | |||
| let maneuverDirectionDescription = decoder.decodeObject(of: NSString.self, forKey: "maneuverDirection") as! String | |||
| let maneuverDirectionDescription = decoder.decodeObject(of: NSString.self, forKey: "maneuverDirection")! as String | |||
There was a problem hiding this comment.
Huh, how’d this ! get here in the first place? This line should read:
guard let maneuverDirectionDescription = … as String? else { return nil }An init?(coder:) method should be able to fail gracefully (hence the ?), because it could be passed absolutely any object for perfectly legitimate reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Swift 3.1 warnings when using xcode 8.3.
/cc @frederoni @1ec5