Add polyline decoding by default, add new test fixture that tests tha… #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,5 +4,6 @@ use_frameworks! | |||
| pod 'NBNRequestKit', :git => 'https://github.com/1ec5/RequestKit.git', :branch => 'mapbox-podspec' | |||
|
|
|||
| target 'MapboxDirectionsTests' do | |||
| pod 'Polyline', '~> 3.0' | |||
There was a problem hiding this comment.
This dependency needs to be added to the implicit target above, like NBNRequestKit. This section is for dependencies specific to the test bundle.
|
@1ec5 fixed the pod mistake - can you add me to BitRise so I can debug the test failure? |
|
Polyline.framework needs to be added as a dependency of the MapboxDirections target in the Xcode project editor. Additionally, the Polyline pod needs to be added as a dependency in the podspec. |
|
@1ec5 I think I have it set that way?
And visually:
|
|
🎉 tests pass! Anything else @1ec5 ? |
|
Nope, merge away! |
…t ability. Fixes #26 * Adds `Polyline` pod dependency
|
🎉 |
1ec5
added a commit
that referenced
this pull request
Apr 7, 2016
#27 made MBRoute.geometry optional, but a route without geometry isn’t much of a route at all. If polyline decoding fails, that means the server returned malformed output. Crash on malformed output.
This was referenced Apr 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t ability.
Fixes #26
Polylinepod dependencycc @1ec5 for the review