New query parameter, waypoint names added to directions options. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the instruction test suite and json file to reflect these new changes.
bsudekum
reviewed
May 8, 2018
| @@ -444,6 +444,11 @@ open class DirectionsOptions: NSObject, NSSecureCoding, NSCopying { | |||
| params.append(URLQueryItem(name: "annotations", value: attributesStrings)) | |||
| } | |||
|
|
|||
| if !waypoints.compactMap({ $0.name }).isEmpty { | |||
| let names = waypoints.map { $0.name ?? "" }.joined(separator: ";") | |||
There was a problem hiding this comment.
Would it be possible to do this map and compactMap once?
There was a problem hiding this comment.
No, because an intermediate waypoint can have no name, but it would still need an empty entry in the semicolon-delimited list.
1ec5
approved these changes
May 9, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectionsOptions.paramsgetter now has a new URLQueryItem added to the array based on mapping all the waypoints to their names.Addresses #271
/ref mapbox/mapbox-navigation-ios#1123
/cc @1ec5, @bsudekum