Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making apiEndpoint and accessToken publicly readable #313

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Making apiEndpoint and accessToken publicly readable #313

merged 2 commits into from
Nov 20, 2018

Conversation

akitchen
Copy link
Contributor

This makes it easier to share this information with other objects which might need it.

Fixes #308

1ec5
1ec5 approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@1ec5 @akitchen
Update CHANGELOG.md
3ec65f3 
Co-Authored-By: akitchen <akitchen@gmail.com>
@akitchen akitchen merged commit 3ec65f3 into master Nov 20, 2018
@akitchen akitchen deleted the publicly-readable-token branch November 20, 2018 04:32
@frederoni frederoni mentioned this pull request Nov 20, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

@JThramer JThramer Awaiting requested review from JThramer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akitchen @1ec5