Ignore empty image URLs #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akitchen
reviewed
Dec 6, 2018
| "imageURL": "", | ||
| ]) | ||
| XCTAssertEqual(component.text, "Take a hike") | ||
| XCTAssertNil(component.imageURL) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
1ec5
force-pushed
the
1ec5-empty-image
branch
from
26fd08e
to
f4a6425
Compare
akitchen
approved these changes
Dec 6, 2018
This was referenced Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where
VisualInstructionComponent(json:)would setVisualInstructionComponent.imageURLto an invalid URL when the JSON representation includes an empty image URL.URL(string:)already returnsnilfor invalid URLs, but appending the resolution and file extension onto an empty string made the string into a valid URL – a relative file URL that would be invalid for an HTTP connection./cc @mapbox/navigation-ios @kevinkreiser