Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store timestamps in response objects #335

Merged
merged 4 commits into from
Feb 1, 2019
Merged

Store timestamps in response objects #335

merged 4 commits into from
Feb 1, 2019

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jan 31, 2019

Added the DirectionsResult.fetchStartDate and DirectionsResult.responseEndDate properties, which can be used to determine the elapsed roundtrip time for a request and response.

/ref mapbox/mapbox-navigation-android#1661
/cc @mapbox/navigation-ios @devotaaabel

@1ec5 1ec5 added the improvement Improvement for an existing feature. label Jan 31, 2019
@1ec5 1ec5 self-assigned this Jan 31, 2019
@1ec5 1ec5 requested a review from JThramer January 31, 2019 17:43
Copy link
Contributor

@akitchen akitchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though it looks like we have a refactoring opportunity in MBDirections.swift to remove duplicated code. Up to you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement for an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants