-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Objective-C compatibility; adopt Swift language features #382
Merged
Merged
Changes from 1 commit
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
c1aad9d
Initial work, replacing enums and the like
a4a78e7
Finishing up. Only remaining thing to do is replace `NSSecureCoding` …
55c6948
Starting on Coder integration and setting up proper swift error type
593efd3
Completed MBDirectionsOptions, things are really coming along now.
a825113
WIP: DirectionsResult and RouteLeg converted.
74e0838
Moving right along, trying to tackle visual instructions and route st…
48406ba
Fixing remaining models and `calculate(options:completionHandler:)` (…
e19066e
Build Success
e03e295
Both examples working now.
0d186e0
Continuing to fix tests
9cffdd3
WIP: Test Fixes
496c4e6
Fixed all tests but V5 tests, which are the only ones remaining.
6149c15
Fixing tests. One remains.
298cd42
Fixing last outstanding test. I hope.
41e3d64
Fixing CI test failures
e08c4bc
Fixing CI test failures
22feb9d
Fixing import issue
7bb9613
hopefully fixing SPM issue once and for all
6baadd5
Fixing build error
eab78de
Clean-up
f3c7ed5
fixing issues with protection level re: OptionSets
f916f83
Adding protocol scheme that allows nav to extend DirectionsError
01fae5e
WIP: Implementing Equatable
064828c
Hashable types are equatable
1ec5 ef7dad0
Streamline geometry conversion
1ec5 d1e6588
Simplified index set creation
1ec5 9ed0230
Import CoreLocation where used
1ec5 78b529d
Updated enum references in documentation
1ec5 2f5f207
These are speeds people walk, not “Mapbox” speeds
1ec5 abfaed3
Updated references to classes in documentation
1ec5 0f24570
Renamed lineString to shape
aaf20a3
Rewrote errors based on LocalizedError
1ec5 4292391
Reverted to JSON-representable objects; implemented JSON comparison
1ec5 e660897
Test Fixes
9a6077e
More test fixes -- instructions
73d129a
Rewrote visual instruction component
1ec5 bf2ebb0
Fixed expectation usage
1ec5 d6dc93a
Fixed intersection test fixture
1ec5 c385ce7
Fixing RouteStepTest
f1504a9
testing
135473a
Fixing all remaining test failures
facce5b
Test structure of rate limiting error
1ec5 1c4a044
Removed extraneous whitespace
1ec5 a310701
Removed extraneous type aliases
1ec5 21b5d03
Corrected indentation; removed extraneous newlines
1ec5 a615877
Removed InstructionFormat
1ec5 d9a1f41
Cleaned up marks; moved Codable, Equatable to extensions
1ec5 9ac36fd
Corrected coordinate bounds documentation
1ec5 69e84a4
Flatten Lane into Intersection
1ec5 1bbecb5
Avoid ExpressibleByStringLiteral for enumeration types
1ec5 0ffc130
Fixed pronunciation coding
1ec5 8ace2aa
Rewrote RouteStep coding
1ec5 486481b
Test round-tripping steps without diffing strings
1ec5 2ef5df9
Flattened example application group structure
1ec5 5f318ed
Removed class prefix from file names
1ec5 9abbc2a
Removed references to CMapboxDirections
1ec5 16e43ff
Renamed map matching group
1ec5 6ae9af5
Alphabetized files in project
1ec5 9542a21
Fixed merge errors with DirectionsPriority
1ec5 f9b2c90
Restored missing documentation comments
1ec5 f594b28
Simplified example map usage
1ec5 8c8c988
Perform bounds checking in release code too
1ec5 7381655
Obviated an implicitly unwrapped optional
1ec5 e22d22b
Updated changelog
1ec5 17c7367
Renamed DirectionsResult shape coding key for consistency
1ec5 08570ec
Corrected Waypoint documentation
1ec5 45cd7ee
Updated some test fixtures
1ec5 a1e3a74
Simplified walking options test
1ec5 62a3d81
Corrected signature of MatchOptions(waypoints:profileIdentifier:)
1ec5 81504bb
Fixed Route documentation
1ec5 9f88ac6
Throw error when decoding without options
1ec5 a0a01d7
Noted source/destination optionality in changelog
1ec5 ce9c013
Test waypoint round-tripping without debug dumps
1ec5 751d7ba
Encode URLs as strings
1ec5 4e0d845
Unit test instructions more thoroughly
1ec5 53c7165
Allow image component format to be SVG
1ec5 c3fa096
Rethrow malformed step coordinate instead of swallowing error
1ec5 ec3cc58
Factored out default driving side
1ec5 094f529
Remove default visual instruction final heading
1ec5 d0f6b7e
Removed dead code
1ec5 7fbf452
Test visual instructions, waypoints
1ec5 713fbd5
Rename Tracepoint.alternateCount; test waypoint equality
1ec5 bc170a0
Removed workarounds for optional enums in Objective-C
1ec5 aaccfcc
Avoid tracking code coverage within tests themselves
1ec5 ff7c2f7
Revert "Avoid tracking code coverage within tests themselves"
1ec5 91fdba3
Test errors
1ec5 373a6e0
Restored CustomStringConvertible conformance
1ec5 9600677
Restored custom Quick Look previews
1ec5 87f6a96
Import Foundation for Linux
1ec5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| ignore: | ||
| - "Directions Example" | ||
| - "Tests" | ||
| - "MapboxDirectionsTests" | ||
|
|
||
| coverage: | ||
| status: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#360 originally intended to omit MapboxDirectionsTests from code coverage metrics, but when #362 renamed this folder to Tests, test code inflated test coverage by around 11%. We’ll need to adjust reapply this change in a separate commit outside of this PR to avoid getting dinged by the (justifiable) omission of test code from code coverage metrics.