Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to initialize route with visual and audio instructions. #430

Merged
merged 5 commits into from
Jun 16, 2020
Merged

Add ability to initialize route with visual and audio instructions. #430

merged 5 commits into from
Jun 16, 2020

Conversation

MaximAlien
Copy link
Contributor

Closes #429.

@MaximAlien MaximAlien requested review from 1ec5 and Udumft June 14, 2020 23:43
@MaximAlien MaximAlien self-assigned this Jun 14, 2020
@MaximAlien MaximAlien mentioned this pull request Jun 14, 2020
Merged
1ec5
1ec5 reviewed Jun 15, 2020
View reviewed changes
Sources/MapboxDirections/DirectionsResult.swift Outdated Show resolved Hide resolved
Sources/MapboxDirections/RouteStep.swift
@@ -475,11 +475,11 @@ open class RouteStep: Codable {
self.codes = codes
self.destinationCodes = destinationCodes
self.destinations = destinations
self.intersections = nil
self.intersections = intersections
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@MaximAlien MaximAlien requested a review from 1ec5 June 15, 2020 19:09
1ec5
1ec5 approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changelog entry:

  • Added the Route(legs:shape:distance:expectedTravelTime:) and Route(from:) initializers. (#430)

@MaximAlien MaximAlien merged commit 6921412 into master Jun 16, 2020
@MaximAlien MaximAlien deleted the maxim/429-route-initialization branch June 16, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

@Udumft Udumft Awaiting requested review from Udumft

Assignees

@MaximAlien MaximAlien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Route initialization
2 participants
@MaximAlien @1ec5