Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix guidance views json parsing. #432

Merged
merged 2 commits into from
Jun 17, 2020
Merged

Fix guidance views json parsing. #432

merged 2 commits into from
Jun 17, 2020

Conversation

fabian-guerra
Copy link
Contributor

Fixes an issue that caused the image url in guidance views to be nil.

@fabian-guerra fabian-guerra requested a review from 1ec5 June 17, 2020 21:35
@fabian-guerra fabian-guerra self-assigned this Jun 17, 2020
1ec5
1ec5 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changelog entry:

  • Fixed an issue where VisualInstruction.Component.guidanceView lacked an image URL. (#432)

Sources/MapboxDirections/VisualInstructionComponent.swift Show resolved Hide resolved
@fabian-guerra fabian-guerra merged commit dffcdfa into master Jun 17, 2020
@fabian-guerra fabian-guerra deleted the fabian-gv-parse-fix branch June 17, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees

@fabian-guerra fabian-guerra

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabian-guerra @1ec5