Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.31.1 #441

Merged
merged 6 commits into from
Jul 31, 2020
Merged

v0.31.1 #441

merged 6 commits into from
Jul 31, 2020

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jul 31, 2020

This PR cherry-picks #440, which fixes a geometry issue when using the Map Matching API, and updates the Xcode project, CocoaPods podspec, and readme for v0.31.1.

/cc @mapbox/navigation-ios @hactar

@1ec5 1ec5 added the build label Jul 31, 2020
@1ec5 1ec5 added this to the v0.31.1 milestone Jul 31, 2020
@1ec5 1ec5 requested a review from MaximAlien July 31, 2020 20:41
@1ec5 1ec5 self-assigned this Jul 31, 2020
@@ -1,2 +1,2 @@
github "raphaelmor/Polyline" ~> 4.2
github "mapbox/turf-swift" ~> 0.3
github "mapbox/turf-swift" ~> 0.3.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to specify the patch version for any pre-v1.0 dependency. Otherwise, both Carthage and CocoaPods will automatically pull down a newer minor version, in this case v0.5.0, causing lots of compiler errors.

We weren’t seeing the issue locally in this repository because of the Cartfile.resolved file. However, Carthage doesn’t look at that file when installing dependencies for downstream projects.

@MaximAlien
Copy link
Contributor

Do we need to update entry in README.md from .package(url: "https://github.com/mapbox/mapbox-directions-swift.git", from: "0.31.0") to .package(url: "https://github.com/mapbox/mapbox-directions-swift.git", from: "0.31.1")?

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 31, 2020

Do we need to update entry in README.md from .package(url: "https://github.com/mapbox/mapbox-directions-swift.git", from: "0.31.0") to .package(url: "https://github.com/mapbox/mapbox-directions-swift.git", from: "0.31.1")?

I think the from: label should result in SPM pulling in v0.31.1 automatically, so it should be fine as is.

@1ec5
Copy link
Contributor Author

1ec5 commented Jul 31, 2020

This build keeps failing because Carthage is pulling in Turf v0.5.0. I thought Carthage doesn’t treat two v0.x versions as being compatible? It doesn’t fail locally for me because it always pulls in v0.3.0.

*** Checking out turf-swift at "v0.5.0"

I think the CircleCI cache is interfering here again.

@MaximAlien
Copy link
Contributor

This build keeps failing because Carthage is pulling in Turf v0.5.0. I thought Carthage doesn’t treat two v0.x versions as being compatible? It doesn’t fail locally for me because it always pulls in v0.3.0.

*** Checking out turf-swift at "v0.5.0"

I think the CircleCI cache is interfering here again.

All tests pass locally on my side. When running Carthage update getting: *** Checking out turf-swift at "v0.3.0".

@@ -13,7 +13,6 @@ commands:
name: Restore cache
keys:
- carthage-v1-{{ .Environment.CIRCLE_JOB }}-{{ checksum "Cartfile.resolved" }}
- carthage-v1-{{ .Environment.CIRCLE_JOB }} # used if checksum fails
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled in fcd43a0 from #427. 🤞

@1ec5 1ec5 merged commit 738b4cd into release-v0.31 Jul 31, 2020
@1ec5 1ec5 deleted the 1ec5-v0.31.1 branch July 31, 2020 22:02
@1ec5
Copy link
Contributor Author

1ec5 commented Jul 31, 2020

Pushed to CocoaPods trunk in CocoaPods/Specs@93e52fb:

--------------------------------------------------------------------------------
 🎉  Congrats

 🚀  MapboxDirections (0.31.1) successfully published
 📅  July 31st, 15:11
 🌎  https://cocoapods.org/pods/MapboxDirections
 👍  Tell your friends!
--------------------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants