Always retain ref if exist #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freenerd
force-pushed
the
retain-ref-always
branch
from
c23db8b to
f914f30
Compare
|
Added a test suite because I like tests. |
1ec5
suggested changes
Nov 16, 2016
| r = Road(name: "Way Name", ref: nil, destination: nil, rotaryName: nil) | ||
| XCTAssertEqual(r.names!, [ "Way Name" ]) | ||
| XCTAssertNil(r.codes) | ||
| r = Road(name: "Way Name 1; Way Name 2", ref: nil, destination: nil, rotaryName: nil) |
There was a problem hiding this comment.
Add a test for values delimited by a colon but not a space, since that's the usual OSM tagging convention.
|
|
||
| // Name only | ||
| r = Road(name: "Way Name", ref: nil, destination: nil, rotaryName: nil) | ||
| XCTAssertEqual(r.names!, [ "Way Name" ]) |
There was a problem hiding this comment.
Force-unwrapping names here will cause the test case to crash on this line if names is nil for some reason. Instead, fall back to an empty array so that this assertion fails but the test can continue and report about other failures.
freenerd
force-pushed
the
retain-ref-always
branch
from
f914f30 to
76426cb
Compare
|
@1ec5 thanks, feedback incorporated |
Add a test suite for Road
freenerd
force-pushed
the
retain-ref-always
branch
from
76426cb to
a1a8ca1
Compare
1ec5
approved these changes
Nov 16, 2016
|
This also made it into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An oversight in #91
It would actually be nice to UnitTest the
Roadclass to document all cases we expect.