Configurable instructions language #94
Conversation
| m = m.replace(/Turn left/g, "Vire à esquerda"); | ||
| m = m.replace(/\bContinue/g, "Continue"); | ||
| m = m.replace(/You have arrived at your destination/g, "Chegou ao seu destino"); | ||
| /* |
There was a problem hiding this comment.
yes, and I still need to add a couple of instructions, but is this the way to do it?
Usage example:
L.mapbox.directions({language: 'pt'});
The default remains english language.
doflip
force-pushed
the
language-hack
branch
from
1b5496c
to
b513883
Compare
|
@doflip thanks for the PR @tmcw how do you feel about this? do you think instead of search/replacing the individual values, we could already here get https://www.transifex.com/ to work? this would down the line make it easier to migrate the changes from mapbox-directions.js to the mapbox directions API (where this eventually should live). Since @doflip likely doesn't want to wait until we get our shit together on the API I'm happy to have this in mapbox-directions.js for a while ... |
|
I think we should land this in the directions API first, rather than it hanging out in the mapbox-directions.js codebase intermediately. Free to use this PR as a fork in the meantime, but we should expedite doing this the right way, on the server side. |
|
Closing this PR, but keeping the branch alive if someone wants to start from it to do client-side translations for the time being: the server-side approach is the plan. |
Usage example:
L.mapbox.directions({language: 'pt'});
The default remains english language.