Incorrect UserAgent (#92)

* FullUserAgent Creation - change string formatting - generate FullUserAgent when creating telemetry client
mapbox · Mar 23, 2018 · bb3d59e · bb3d59e
1 parent 71dc5be
commit bb3d59e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/libtelemetry/src/main/java/com/mapbox/android/telemetry/MapboxTelemetry.java b/libtelemetry/src/main/java/com/mapbox/android/telemetry/MapboxTelemetry.java
@@ -304,7 +304,9 @@ private void initializeTelemetryClient() {
   }
 
   private TelemetryClient createTelemetryClient(String accessToken, String userAgent) {
-    TelemetryClientFactory telemetryClientFactory = new TelemetryClientFactory(accessToken, userAgent, new Logger());
+    String fullUserAgent = TelemetryUtils.createFullUserAgent(userAgent, applicationContext);
+    TelemetryClientFactory telemetryClientFactory = new TelemetryClientFactory(accessToken, fullUserAgent,
+      new Logger());
     telemetryClient = telemetryClientFactory.obtainTelemetryClient(applicationContext);
 
     return telemetryClient;

diff --git a/libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryUtils.java b/libtelemetry/src/main/java/com/mapbox/android/telemetry/TelemetryUtils.java
@@ -17,7 +17,7 @@ public class TelemetryUtils {
   static final String MAPBOX_SHARED_PREFERENCE_KEY_VENDOR_ID = "mapboxVendorId";
   private static final String DATE_AND_TIME_PATTERN = "yyyy-MM-dd'T'HH:mm:ss.SSSZ";
   private static final String EMPTY_STRING = "";
-  private static final String TWO_STRING_FORMAT = "%s%s";
+  private static final String TWO_STRING_FORMAT = "%s %s";
   private static final String THREE_STRING_FORMAT = "%s/%s/%s";
   private static final SimpleDateFormat dateFormat = new SimpleDateFormat(DATE_AND_TIME_PATTERN, Locale.US);
   private static final Locale DEFAULT_LOCALE = Locale.US;