Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nav event creation code from the mapbox-events-android library #204

Closed
lilykaiser opened this issue Aug 28, 2018 · 6 comments · Fixed by #383 or mapbox/mapbox-navigation-android#1890
Closed

Remove nav event creation code from the mapbox-events-android library #204

lilykaiser opened this issue Aug 28, 2018 · 6 comments · Fixed by #383 or mapbox/mapbox-navigation-android#1890
Assignees
@Chaoba
Labels
enhancement high priority

Comments

@lilykaiser
Copy link

lilykaiser commented Aug 28, 2018 •
edited
Loading

Per internal conversation, step 4 in the effort to streamline tracking event ingestion is to refactor event creation code (classes, factories, test, etc...) into the nav SDK and out of mapbox-android-events. Creating this ticket as a placeholder.

Related maps ticket: #203
This was referenced Aug 28, 2018
Closed
Closed
@Chaoba Chaoba mentioned this issue Apr 12, 2019
Merged
@andrlee andrlee assigned Chaoba and unassigned electrostat Apr 15, 2019
@Chaoba
Copy link
Contributor

Chaoba commented Apr 16, 2019

Related PR in telemetry.

@Chaoba Chaoba mentioned this issue Apr 16, 2019
Merged
19 tasks
@Chaoba
Copy link
Contributor

Chaoba commented Apr 16, 2019

PR in nav sdk

@Chaoba
Copy link
Contributor

Chaoba commented Apr 30, 2019

@chriswu42.

@Chaoba Chaoba reopened this Apr 30, 2019
@andrlee
Copy link
Contributor

andrlee commented May 6, 2019 •
edited
Loading

@Chaoba why are we reopening this ticket?

@Chaoba
Copy link
Contributor

Chaoba commented May 6, 2019

@andrlee we haven't done it in nav part.

@andrlee
Copy link
Contributor

andrlee commented May 20, 2019

closing PR: #383 merged

@andrlee andrlee closed this as completed May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chaoba Chaoba

Labels
enhancement high priority
Projects
None yet
Milestone
No milestone
4 participants
@andrlee @electrostat @Chaoba @lilykaiser