Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nav event creation related codes #383

Merged
merged 4 commits into from
Apr 28, 2019
Merged

Remove nav event creation related codes #383

merged 4 commits into from
Apr 28, 2019

Conversation

Chaoba
Copy link
Contributor

@Chaoba Chaoba commented Apr 12, 2019

Fix #204
Remove nav event creation related code and corresponding test code.

Corresponding PR in nav sdk

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #383 into master will increase coverage by 6.09%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #383      +/-   ##
============================================
+ Coverage     62.04%   68.14%   +6.09%     
+ Complexity      517      348     -169     
============================================
  Files            98       63      -35     
  Lines          2967     2009     -958     
  Branches        208      150      -58     
============================================
- Hits           1841     1369     -472     
+ Misses         1026      552     -474     
+ Partials        100       88      -12

@Chaoba Chaoba self-assigned this Apr 15, 2019
Copy link
Contributor

@andrlee andrlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we think about removing serializers:

?
Can you please also add a link to the PR in navigation sdk repo for visibility?

@Chaoba
Copy link
Contributor Author

Chaoba commented Apr 16, 2019

Should we think about removing serializers:

@andrlee We already removed this method in this PR.

@andrlee
Copy link
Contributor

andrlee commented Apr 16, 2019

@Chaoba if that's true then that might be a problem since these serializers have to be registered for nav events to work.
/cc @Guardiola31337

@Chaoba
Copy link
Contributor Author

Chaoba commented Apr 16, 2019

@andrlee The reason why we need these serializers is because in nav related Events there will be a variable with type NavigationMetadata .etc and Gson can't serializers it by default.

Since we will move all nav events to nav sdk, telemetry should not have any dependency on it and then we need to remove configureGsonBuilder() in this PR.

My solution is that we create a NavBaseEvent that will have variables in NavigationMetadata in nav sdk and let all other event inherit it, so we will eliminate self define class and Gson could serializer these events by default.

@Chaoba Chaoba force-pushed the kl-nav branch 3 times, most recently from 6c8a086 to ace3a91 Compare April 17, 2019 09:39
@Chaoba
Copy link
Contributor Author

Chaoba commented Apr 28, 2019

@andrlee This PR is good to go, will merge to master and test nav sdk with snapshot release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nav event creation code from the mapbox-events-android library
2 participants