Make MMEUniqueIdentifier thread-safe

mapbox · Sep 29, 2021 · c353240 · c353240
1 parent c37c75a
commit c353240
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/Sources/MapboxMobileEvents/MMEUniqueIdentifier.m b/Sources/MapboxMobileEvents/MMEUniqueIdentifier.m
@@ -2,6 +2,7 @@
 
 @interface MMEUniqueIdentifier ()
 
+@property (nonatomic, strong, readonly) NSLock *lock;
 @property (nonatomic) NSDate *instanceIDRotationDate;
 @property (nonatomic) NSString *instanceID;
 
@@ -12,19 +13,23 @@ @implementation MMEUniqueIdentifier
 - (instancetype)initWithTimeInterval:(NSTimeInterval)timeInterval {
  if (self = [super init]) {
  _timeInterval = timeInterval;
+ _lock = [[NSLock alloc] init];
  }
  return self;
 }
 
 - (NSString *)rollingInstanceIdentifer {
+ [self.lock lock];
  if (self.instanceIDRotationDate && [[NSDate date] timeIntervalSinceDate:self.instanceIDRotationDate] >= 0) {
  _instanceID = nil;
  }
  if (!_instanceID) {
  _instanceID = [[NSUUID UUID] UUIDString];
  self.instanceIDRotationDate = [[NSDate date] dateByAddingTimeInterval:self.timeInterval];
  }
- return _instanceID;
+ NSString *instanceID = _instanceID;
+ [self.lock unlock];
+ return instanceID;
 }
 
 @end