Fix missing location telemetry events #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to rescheduling some telemetry event to custom dispatch queue the self.locationManager getter (that includes instantiation logic) was called on the non-main queue. CLLocationManager requires to have NSRunLoop in the constructor thread. Instantiation in non-main queue was an unexpected change
S2Ler
reviewed
Sep 21, 2022
| if ([NSThread isMainThread]) { | ||
| instantiateLocationManager(); | ||
| } else { | ||
| dispatch_sync(dispatch_get_main_queue(), instantiateLocationManager); |
There was a problem hiding this comment.
Not yet deprecated 🤡
S2Ler
approved these changes
Sep 21, 2022
tarigo
approved these changes
Sep 21, 2022
This reverts commit dd24027.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to rescheduling some telemetry event to custom dispatch queue the self.locationManager getter (that includes instantiation logic) was called on the non-main queue.
CLLocationManager requires to have NSRunLoop in the constructor thread.
Instantiation in non-main queue was an unexpected change
plus:
Fixes https://mapbox.atlassian.net/browse/CORESDK-1286