Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set location manager's delegate to nil before deallocating #55

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Set location manager's delegate to nil before deallocating #55

merged 1 commit into from
Aug 3, 2018

Conversation

julianrex
Copy link
Contributor

@julianrex julianrex commented Aug 3, 2018 •
edited
Loading

CLLocationManager's delegate property is declared as assign - so needs to be nil'd whenever the instance containing the location manager is about to be deallocated.

This may partially address #54 and #50 - though it also requires a related change in MGLMapView.

@julianrex julianrex requested a review from rclee August 3, 2018 14:57
@julianrex julianrex added the crash label Aug 3, 2018
rclee
rclee approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@rclee rclee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julianrex 👍

@julianrex julianrex merged commit cc9fcbe into master Aug 3, 2018
@julianrex julianrex deleted the jrex/location-manager-delegate branch August 3, 2018 15:36
@rclee rclee mentioned this pull request Aug 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rclee rclee rclee approved these changes

Assignees
No one assigned
Labels
crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianrex @rclee