Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete string values #62

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Remove obsolete string values #62

merged 1 commit into from
Mar 13, 2019

Conversation

LukasPaczos
Copy link
Contributor

Refs mapbox/mapbox-gl-native#14078 (comment).

Hopefully fixes:

../../src/main/res/values/strings.xml:2: Overriding @string/app_name which is marked as private in com.mapbox.mapboxsdk:mapbox-android-sdk. If deliberate, use tools:override="true", otherwise pick a different name.

@LukasPaczos LukasPaczos added this to the v0.5.0 milestone Mar 12, 2019
@LukasPaczos LukasPaczos requested a review from tobrun March 12, 2019 13:08
@LukasPaczos LukasPaczos mentioned this pull request Mar 12, 2019
Closed
@LukasPaczos LukasPaczos merged commit 47b7f45 into master Mar 13, 2019
@LukasPaczos LukasPaczos deleted the lp-remove-string-values branch March 13, 2019 17:48
@LukasPaczos LukasPaczos mentioned this pull request Apr 16, 2019
Closed
13 tasks
@LukasPaczos LukasPaczos modified the milestones: v0.5.0, v0.4.1 Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasPaczos @tobrun