Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In key event handler, check for map canvas using classList.contains() #1165

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

neodescis
Copy link
Contributor

fix #1135

Had to update test events to include a contains() function.

Copy link
Contributor

@stepankuzmin stepankuzmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @neodescis 👍

@stepankuzmin stepankuzmin merged commit acd3500 into mapbox:main Mar 6, 2023
@neodescis neodescis deleted the use-classlist-contains branch March 6, 2023 15:20
gynekolog pushed a commit to gynekolog/mapbox-gl-draw that referenced this pull request Jun 5, 2023
…eodescis)

Co-authored-by: Nick Steinbaugh <nsteinbaugh@icr-team.com>
gynekolog pushed a commit to gynekolog/mapbox-gl-draw that referenced this pull request Jun 5, 2023
…eodescis)

Co-authored-by: Nick Steinbaugh <nsteinbaugh@icr-team.com>
danielsippel added a commit to danielsippel/mapbox-gl-draw that referenced this pull request Apr 17, 2024
danielsippel added a commit to danielsippel/mapbox-gl-draw that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard events are not handled when using maplibre-gl-js
2 participants