Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming major v4 release #197

Closed
scottsfarley93 opened this issue Mar 13, 2019 · 7 comments
Closed

Upcoming major v4 release #197

scottsfarley93 opened this issue Mar 13, 2019 · 7 comments
Milestone

Comments

@scottsfarley93
Copy link

There are several outstanding issues and feature improvements that would improve the usability, look/feel, and result relevance of the plugin. I suspect that some of these changes may be large and/or breaking, so I think targeting this as a v4 major release seems reasonable.

Here's the list of tickets that we've prioritized but totally open to suggestions about other features/bugs that should also make the list.

#51 - camera animation properties
#99 - result event emitted twice
#115 - expose the clear method as public
#162 - accessibility issues
#153 - include matching text
#176 - expose setOptions method
#150 - localize placeholder text
#89 - mobile styling
#167 - minor style tweak
#157 - async local geocoder
#195 - new default options
#196 - feedback widget

\cc @mapbox/search @katydecorah @yuletide @kbauhaus @andrewharvey

@scottsfarley93 scottsfarley93 added this to the v4.0.0 milestone Mar 13, 2019
@scottsfarley93
Copy link
Author

Noting several other features/fixes that will be included:

@andrewharvey
Copy link
Collaborator

To help track this, should we close issues when they are merged into the version4 branch?

@scottsfarley93
Copy link
Author

@andrewharvey we can certainly do that. It might be confusing, however, since the changes will not be deployed in the plugin until version 4 lands in master -- they'll just be waiting in the version 4 working branch. Happy to do whatever makes the most sense.

@scottsfarley93 scottsfarley93 mentioned this issue Mar 20, 2019
4 tasks
@andrewharvey
Copy link
Collaborator

GL JS closes tickets once the PR is merged, not when the release is made. I think that's a good model, it makes it clearer which issues still need to be implemented and which are already done.

My vote would be we close them once merged into v4 branch.

@scottsfarley93
Copy link
Author

👍 we can start doing this.

@andrewharvey andrewharvey changed the title Upcoming major release Upcoming major v4 release Mar 21, 2019
@scottsfarley93
Copy link
Author

The version 4 working branch is looking pretty close to being in shape for an initial beta release. I think we can ship a v4.0.0-beta.0 at some point tomorrow after which time we can ensure all the examples work as expected. We can address any problems we uncover in the beta over the next week or two and then plan to cut a new full release around April 8.

@scottsfarley93 scottsfarley93 mentioned this issue Apr 9, 2019
4 tasks
@scottsfarley93
Copy link
Author

🎉 v4.0.0 released!

See https://github.com/mapbox/mapbox-gl-geocoder/releases/tag/v4.0.0 and https://www.npmjs.com/package/@mapbox/mapbox-gl-geocoder/v/4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants