Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default placeholder text should be localized if language option provided #150

Closed
vfoss opened this issue Apr 13, 2018 · 2 comments
Closed
Milestone

Comments

@vfoss
Copy link

vfoss commented Apr 13, 2018

The placeholder text in the search bar for the geocoder remains "Search" (in English), even when the language of the map is changed, as in
let geocoder = new MapboxGeocoder({accessToken: mapboxgl.accessToken, language: 'es' });. I cannot figure out a clean way to change it.

@andrewharvey
Copy link
Collaborator

andrewharvey commented Apr 13, 2018

@vfoss You can set it with the placeholder option.

But let's leave this ticket open to make the default placeholder set by the first language if provided.

@andrewharvey andrewharvey changed the title Changing geocoder language does not change the word "Search" default placeholder text should be localized if language option provided Apr 13, 2018
@scottsfarley93 scottsfarley93 added this to the v4.0.0 milestone Mar 13, 2019
@andrewharvey
Copy link
Collaborator

Done in https://github.com/mapbox/mapbox-gl-geocoder/tree/version4 by #201, slated for v4 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants