Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] add mobile styles #233

Merged
merged 2 commits into from
Mar 27, 2019
Merged

[v4] add mobile styles #233

merged 2 commits into from
Mar 27, 2019

Conversation

katydecorah
Copy link
Contributor

  • briefly describe the changes in this PR
  • [ ] write tests for all new functionality
  • [ ] run npm run docs and commit changes to API.md
  • update CHANGELOG.md with changes under master heading before merging

This PR adds styles for a better experience on smaller screens:

  • increases font-size of input
  • increases width and height of input for a larger hit box
  • increases font-size of results

Also fixes the fantom gray background on the clear button #211 (comment)

Refs #89

@yuletide can you take a look at this branch to see if these styles help improve some of the issues you were seeing in #89 (comment) ?

cc @scottsfarley93

Copy link

@scottsfarley93 scottsfarley93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 styling looks good to me.

Unable been able to play with it on a real phone to see if it fixes the problems @yuletide notes in #89 (comment) but from the devtools mobile view it looks 🔥

@yuletide
Copy link
Contributor

yuletide commented Mar 26, 2019

Looks good, except I'm not seeing the width: 100% working
image

Not quite sure why.

Edit: Some of this is due to how we have the demo page setup. But when I set mapboxgl-ctrl-top-right to width: 100% I get full width but margin issues on the left side. Trying to recall how I solved this before.

Copy link

@scottsfarley93 scottsfarley93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

@scottsfarley93 scottsfarley93 merged commit 895f569 into version4 Mar 27, 2019
@scottsfarley93 scottsfarley93 deleted the v4-mobile branch March 27, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants